Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changed the order of the report #27260

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: Changed the order of the report #27260

merged 1 commit into from
Sep 20, 2024

Conversation

hjetpoluru
Copy link
Contributor

@hjetpoluru hjetpoluru commented Sep 18, 2024

Description

I noticed that the test scenario successfully passed but immediately showed as a failure due to the snapshot check that happens after the console statement. This could be causing confusion, so with the suggestion by @HowardBraham changed the order to report success at the end.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Check the order of the report.

Screenshots/Recordings

Before

Screenshot 2024-09-18 at 1 46 41 PM

After

Screenshot 2024-09-18 at 2 04 10 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@hjetpoluru hjetpoluru added team-extension-platform area-qa Relating to QA work (Quality Assurance) labels Sep 18, 2024
@hjetpoluru hjetpoluru self-assigned this Sep 18, 2024
@hjetpoluru hjetpoluru requested a review from a team as a code owner September 18, 2024 18:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 18, 2024

Copy link
Contributor

@HowardBraham HowardBraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out together!

@metamaskbot
Copy link
Collaborator

Builds ready [d1c0b93]
Page Load Metrics (2127 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21625791556876421
domContentLoaded168026022101260125
load168526302127267128
domInteractive218243178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru merged commit 9611708 into develop Sep 20, 2024
86 checks passed
@hjetpoluru hjetpoluru deleted the fix-order-report branch September 20, 2024 00:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants